Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to esbuild 0.19 #350

Closed
wants to merge 1 commit into from

Conversation

nwalters512
Copy link
Contributor

This PR upgrades to the latest version of esbuild.

There are now two copies of esbuild installed in development, aas pkgroll is still using esbuild 0.18. I'd be happy to file a PR against that repository as well.

@privatenumber
Copy link
Owner

Thanks but we had to revert due to a change in how esbuild compiles require():

esbuild-kit/core-utils#47

Closing this for now.

@nwalters512
Copy link
Contributor Author

Thanks for linking to that other issue. I did search in this repository and check the Git blame before opening this PR, but the fact that it was in a different repository explains why I didn't see it!

@nwalters512 nwalters512 deleted the esbuild-0.19 branch October 21, 2023 04:42
@LukeNotable
Copy link

Well, I had the same problem with sharp as Mariuz, and I just tried his repo, using the latest tsx with a resolution for [email protected], and suddenly at least that issue with sharp has gone away. Strange, since the bug in esbuild is still there. Did tsx accidentally implement a workaround somewhere along the way?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants