feat: support tsconfig paths #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/specs/builds/typescript.ts
Outdated
| expect(pkgrollProcess.exitCode).toBe(0); | ||
| expect(pkgrollProcess.stderr).toBe(''); | ||
|
|
||
| /** @todo expect */ |
There was a problem hiding this comment.
I think that the preceding expectations (no errors during pkgrollProcess) are sufficient. On the other hand I couldn't come up with a simple test due to the complexity of the fixtures. Maybe on could reduce the latter.
2 tasks
|
I refactored the plugin a bit. Thanks for the PR and the contribution! Great PR and looking forward to collaborating with you more :) |
|
🎉 This issue has been resolved in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for the tsconfig compiler options
pathsandbaseUrland solves #48fs-fixturesdoes not have all permissions.pnpm run lintfails due to 'ERR_MODULE_NOT_FOUND'. 'Did you mean to import [email protected]/node_modules/eslint-plugin-no-use-extend-native/index.js?' Don't know exactly why yet. Could be lintroll or my setup.Please bear with me because it's my first time working with pnpm and under the hood of rollup.
Cheers