This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaharagon
added
🌐 website issue
*Technical* issues with the website.
🏠 housekeeping
Anything primarily related to site cleanup.
👁️ browsers
labels
Aug 13, 2019
Deploy preview for privacytools-io ready! Built with commit d8e9135 |
nitrohorse
reviewed
Aug 13, 2019
nitrohorse
previously approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 👍
Mikaela
previously approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
blacklight447
previously approved these changes
Aug 13, 2019
jonaharagon
commented
Aug 13, 2019
Browser-agnostic description
jonaharagon
dismissed stale reviews from blacklight447, Mikaela, and nitrohorse
via
August 13, 2019 17:33
d8e9135
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
👁️ browsers
🏠 housekeeping
Anything primarily related to site cleanup.
🌐 website issue
*Technical* issues with the website.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered the sub-navigations for "browser" and "os" to make more logical sense, not sure why they were alphabetized with the rest.
Renamed sections to be browser-agnostic.
Added support for adding links to platform icons in cardv2.html:
Icons left blank (as they all currently are) will remain functionally the same, for example:
However, adding a link to one:
...will add a hyperlink to that icon (the same way the Git icons are currently linked), allowing us to link to download pages for various platforms. All platform icons now support this functionality, although it will be most useful for linking browser extensions. I did not find and add links to each platform in this PR.