Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Small Improvements #1149

Merged
merged 5 commits into from
Aug 13, 2019
Merged

Small Improvements #1149

merged 5 commits into from
Aug 13, 2019

Conversation

jonaharagon
Copy link
Contributor

Reordered the sub-navigations for "browser" and "os" to make more logical sense, not sure why they were alphabetized with the rest.

Renamed sections to be browser-agnostic.

Added support for adding links to platform icons in cardv2.html:

Icons left blank (as they all currently are) will remain functionally the same, for example:

firefox=""
chrome=""
safari=""
opera=""
edge=""
android=""

However, adding a link to one:

chrome="https://chrome.google.com/webstore/detail/ublock-origin/cjpalhdlnbpafiamejdnhcphjbkeiagm?hl=en"

...will add a hyperlink to that icon (the same way the Git icons are currently linked), allowing us to link to download pages for various platforms. All platform icons now support this functionality, although it will be most useful for linking browser extensions. I did not find and add links to each platform in this PR.

@jonaharagon jonaharagon added 🌐 website issue *Technical* issues with the website. 🏠 housekeeping Anything primarily related to site cleanup. 👁️ browsers labels Aug 13, 2019
@jonaharagon jonaharagon requested review from nitrohorse and a team August 13, 2019 04:55
@netlify
Copy link

netlify bot commented Aug 13, 2019

Deploy preview for privacytools-io ready!

Built with commit d8e9135

https://deploy-preview-1149--privacytools-io.netlify.com

_includes/nav.html Outdated Show resolved Hide resolved
nitrohorse
nitrohorse previously approved these changes Aug 13, 2019
Copy link
Contributor

@nitrohorse nitrohorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 👍

Mikaela
Mikaela previously approved these changes Aug 13, 2019
Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blacklight447 blacklight447 self-requested a review August 13, 2019 09:29
blacklight447
blacklight447 previously approved these changes Aug 13, 2019
_includes/nav.html Outdated Show resolved Hide resolved
Browser-agnostic description
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
👁️ browsers 🏠 housekeeping Anything primarily related to site cleanup. 🌐 website issue *Technical* issues with the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants