-
-
Notifications
You must be signed in to change notification settings - Fork 385
instant-messenger: change Riot privacy conern link to #1049 #1050
Conversation
Deploy preview for privacytools-io ready! Built with commit eb0221b |
I tend to be in favour of this PR and against #1047. But i have to catch up on the discussions before giving a fully informed opinion. |
I have removed the description from this PR and the first commit as this appears to be more popular PR and in another commit I fixed the tooltip text that was leftover from the old link. My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again.
I agree. Based on the issues listed in https://github.com/privacytoolsIO/privacytools.io/issues/1049 I think we should remove Riot for now. We could also bump it to the "Worth Mentioning" section with the "privacy conerns" tooltip warning users but that wouldn’t be my first choice.
You are missing a closing element on your second anchor link: |
Do I understand correctly that you are requesting changes to block merging of this and will be giving an approving review to https://github.com/privacytoolsIO/privacytools.io/pull/1047 ?
I disagree as Riot is not an instant messenger for people, but teams, and would be blocked by https://github.com/privacytoolsIO/privacytools.io/issues/1065.
Could you clarify what is wrong in the file and what should it be instead? I looked at it a few times, but I don't spot the issue. I find the code too confusing :( |
Yeah 👍🏼 I’ll make an approving review of 1047.
Ah I see, that makes sense. |
I think it's actually an inherited error from the existing version, but the html should be this:
Add a ">" before the "<span" so it is valid HTML. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine merging this immediately if the syntax issues mentioned here were fixed, although I'm equally fine with not fixing this if we were to merge #1047 instead.
Co-Authored-By: Jonah Aragon <[email protected]>
No description provided.