Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improvements on Windows overview #2606

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

dngray
Copy link
Member

@dngray dngray commented Jun 2, 2024

Changes proposed in this PR:

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

Copy link

github-actions bot commented Jun 2, 2024

Your preview is ready!

Name Link
🔨 Latest commit e92210a
😎 Preview https://2606--glowing-salamander-8d7127.netlify.app/

dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 93b6b34 to 7047551 Compare June 2, 2024 09:01
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 7047551 to 2fa8410 Compare June 2, 2024 09:40
@dngray dngray marked this pull request as draft June 2, 2024 09:44
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 2fa8410 to 92c4c13 Compare June 2, 2024 09:50
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 92c4c13 to 53af4c7 Compare June 2, 2024 10:17
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 53af4c7 to 27ab49a Compare June 2, 2024 10:20
docs/os/windows/index.md Outdated Show resolved Hide resolved
Copy link
Member Author

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments for discussion

dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from de883d2 to c485fb0 Compare June 2, 2024 10:30
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from c485fb0 to 2e356ac Compare June 2, 2024 10:32
Copy link
Contributor

@rollsicecream rollsicecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes here and there.

docs/os/windows/index.md Outdated Show resolved Hide resolved
docs/os/windows/index.md Outdated Show resolved Hide resolved
docs/os/windows/index.md Outdated Show resolved Hide resolved
docs/os/windows/index.md Outdated Show resolved Hide resolved
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 2e356ac to cb7c8c0 Compare June 2, 2024 11:24
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to give this some thought. I don't think these changes capture the original intent of the Windows guides being added though, and omit some key details. This almost reads as if Windows is recommended, which I don't think is our goal.

@dngray
Copy link
Member Author

dngray commented Jun 2, 2024

This almost reads as if Windows is recommended, which I don't think is our goal.

I don't think it does that at all. I reworded some sentences to a more neutral tone which brings it more in line with the other content already on the site. The main thing people will care about is the guides that we actually provide (which are currently marked as "coming soon").

I also haven't really removed anything except for some of the repetitiveness, and mentions of "editions". I did remove the recommendation to stick with Windows 10, as this isn't helpful to anyone who buys a device shipped with Windows 11 OEM.

Also in some cases Windows 11 has things which Windows 10 does not, for example DNS over HTTPS as part of the system resolver.

dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch 2 times, most recently from 3bbf8a6 to 789de88 Compare June 2, 2024 15:15
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 789de88 to 5cf0413 Compare June 2, 2024 15:20
@dngray dngray marked this pull request as ready for review June 2, 2024 15:21
docs/security-keys.md Outdated Show resolved Hide resolved
docs/os/windows/index.md Outdated Show resolved Hide resolved
docs/os/windows/index.md Outdated Show resolved Hide resolved
@friadev friadev mentioned this pull request Jul 14, 2024
1 task
Copy link
Member Author

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

dngray added a commit that referenced this pull request Jul 14, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 34f5eee to 23768d3 Compare July 14, 2024 17:38
dngray added a commit that referenced this pull request Jul 14, 2024
@dngray dngray force-pushed the pr-improvements-overview branch from 23768d3 to fc9d8f9 Compare July 14, 2024 17:40
docs/os/windows/index.md Outdated Show resolved Hide resolved
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggestions mostly around wording and breaking large paragraphs into smaller ones for readability.

docs/os/windows/index.md Show resolved Hide resolved
docs/os/windows/index.md Show resolved Hide resolved
docs/os/windows/index.md Show resolved Hide resolved
docs/os/windows/index.md Show resolved Hide resolved
docs/os/windows/index.md Show resolved Hide resolved
docs/os/index.md Outdated Show resolved Hide resolved
docs/os/windows/index.md Show resolved Hide resolved
Copy link
Member Author

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes look good to me.

dngray added a commit that referenced this pull request Jul 24, 2024
Co-authored-by: Redoomed <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
@dngray dngray force-pushed the pr-improvements-overview branch from 6fe2632 to e97c2a2 Compare July 24, 2024 14:49
Co-authored-by: Redoomed <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
@dngray dngray force-pushed the pr-improvements-overview branch from e97c2a2 to e92210a Compare July 25, 2024 07:08
@dngray dngray merged commit e92210a into main Jul 25, 2024
16 checks passed
@dngray dngray deleted the pr-improvements-overview branch July 25, 2024 07:09
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/windows-guide/250/288

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-28/19709/1

dngray added a commit to IkelAtomig/privacyguides.org that referenced this pull request Jul 28, 2024
dngray added a commit to IkelAtomig/privacyguides.org that referenced this pull request Jul 28, 2024
dngray added a commit to IkelAtomig/privacyguides.org that referenced this pull request Jul 28, 2024
@ave9858
Copy link

ave9858 commented Jul 29, 2024

I still don't think "The official Media Creation Tool is the best way to put a Windows installer on a USB flash drive. Third-party tools like Rufus or Etcher may unexpectedly modify the files, which could lead to boot issues or other troubles when installing." is accurate. Etcher doesn't even work for Windows ISOs because it only copies raw data, and rufus won't make any modifications that the user doesn't approve of and is probably safer than using the media creation tool

@jonaharagon
Copy link
Member

and rufus [...] is probably safer than using the media creation tool

why's this?

@dngray
Copy link
Member Author

dngray commented Jul 29, 2024

You can do it without any tools at all if you like 😄

Assuming:
J:\ = USB stick
V:\ = Mounted ISO.

  1. Open up cmd.exe and start DISKPART

    C:\Users\user>Start DISKPART
    Microsoft DiskPart version 6.1.7601
    Copyright (C) 1999-2008 Microsoft Corporation.
    On computer: DESKTOP-PC
    DISKPART> LIST DISK
      Disk ###  Status         Size     Free     Dyn  Gpt
      --------  -------------  -------  -------  ---  ---
      Disk 0    Online          119 GB      0 B
      Disk 1    Online         2794 GB      0 B        *
      Disk 2    Online          111 GB  1024 KB
      Disk 3    Online          698 GB  1024 KB        *
      Disk 4    No Media           0 B      0 B
      Disk 5    No Media           0 B      0 B
      Disk 6    Online           29 GB      0 B
    
  2. Select a disk

    DISKPART> SELECT DISK 6
    Disk 6 is now the selected disk.
    
  3. Clean disk

    DISKPART> CLEAN
    DiskPart succeeded in cleaning the disk.
    
  4. Create a primary partition

    DISKPART> CREATE PARTITION PRIMARY
    DiskPart succeeded in creating the specified partition.
    
  5. Select it

    DISKPART> SELECT PARTITION 1
    Partition 1 is now the selected partition.
    
  6. Make the boot portion active

    DISKPART> ACTIVE
    DiskPart marked the current partition as active.
    
  7. Format the disk ready for use

    DISKPART> FORMAT FS=NTFS QUICK
      100 percent completed
    DiskPart successfully formatted the volume.
    
  8. Set disk as active

    DISKPART> ACTIVE
    DiskPart marked the current partition as active.
    
  9. Run cmd.exe as Administrator:

  10. Mount Windows .iso

  11. Create a BOOT directory

  12. Create a boot sector on V:

    C:\Windows\system32>cd V:\BOOT
    C:\Windows\system32>V:
    V:\boot>BOOTSECT /NT60 J:
    Target volumes will be updated with BOOTMGR compatible bootcode.
    J: (\\?\Volume{9dffb40d-f33e-11e1-896c-abac436880d7})
        Successfully updated NTFS filesystem bootcode.
    Bootcode was successfully updated on all targeted volumes.
    
  13. Copy files to V:

    V:\boot>XCOPY V:\ J:\ /S/E
    

Been doing that from windows 7, 8, 10 & 11.

@ave9858
Copy link

ave9858 commented Jul 29, 2024

why's this?

Rufus can be used with ISOs download from Microsoft, which can be hashed to check integrity and also has features to guard against bad USB hardware like bad block checking and the new runtime UEFI media validation. Rufus is also FOSS and is even recommended by Microsoft in some of their documentation, gives the user more control, and has some QOL features.

Edit: Rufus is recommended on https://learn.microsoft.com/en-us/windows-insider/build-expiration#reinstall-windows-with-a-windows-insider-beta-channel-iso, which links to https://aka.ms/WIPbootISO which is a post by a Microsoft employee showing how to use rufus

redoomed1 pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Jan 6, 2025
redoomed1 pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Jan 6, 2025
redoomed1 pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Jan 14, 2025
redoomed1 pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants