-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improvements on Windows overview #2606
Conversation
✅ Your preview is ready!
|
93b6b34
to
7047551
Compare
7047551
to
2fa8410
Compare
2fa8410
to
92c4c13
Compare
92c4c13
to
53af4c7
Compare
53af4c7
to
27ab49a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments for discussion
de883d2
to
c485fb0
Compare
c485fb0
to
2e356ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some fixes here and there.
2e356ac
to
cb7c8c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to give this some thought. I don't think these changes capture the original intent of the Windows guides being added though, and omit some key details. This almost reads as if Windows is recommended, which I don't think is our goal.
I don't think it does that at all. I reworded some sentences to a more neutral tone which brings it more in line with the other content already on the site. The main thing people will care about is the guides that we actually provide (which are currently marked as "coming soon"). I also haven't really removed anything except for some of the repetitiveness, and mentions of "editions". I did remove the recommendation to stick with Windows 10, as this isn't helpful to anyone who buys a device shipped with Windows 11 OEM. Also in some cases Windows 11 has things which Windows 10 does not, for example DNS over HTTPS as part of the system resolver. |
3bbf8a6
to
789de88
Compare
789de88
to
5cf0413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
34f5eee
to
23768d3
Compare
23768d3
to
fc9d8f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor suggestions mostly around wording and breaking large paragraphs into smaller ones for readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look good to me.
Co-authored-by: Redoomed <[email protected]> Signed-off-by: Jonah Aragon <[email protected]>
6fe2632
to
e97c2a2
Compare
Co-authored-by: Redoomed <[email protected]> Signed-off-by: Jonah Aragon <[email protected]>
e97c2a2
to
e92210a
Compare
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
I still don't think "The official Media Creation Tool is the best way to put a Windows installer on a USB flash drive. Third-party tools like Rufus or Etcher may unexpectedly modify the files, which could lead to boot issues or other troubles when installing." is accurate. Etcher doesn't even work for Windows ISOs because it only copies raw data, and rufus won't make any modifications that the user doesn't approve of and is probably safer than using the media creation tool |
why's this? |
You can do it without any tools at all if you like 😄Assuming:
Been doing that from windows 7, 8, 10 & 11. |
Rufus can be used with ISOs download from Microsoft, which can be hashed to check integrity and also has features to guard against bad USB hardware like bad block checking and the new runtime UEFI media validation. Rufus is also FOSS and is even recommended by Microsoft in some of their documentation, gives the user more control, and has some QOL features. Edit: Rufus is recommended on https://learn.microsoft.com/en-us/windows-insider/build-expiration#reinstall-windows-with-a-windows-insider-beta-channel-iso, which links to https://aka.ms/WIPbootISO which is a post by a Microsoft employee showing how to use rufus |
Changes proposed in this PR:
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.