Minify HTML & CSS #1351
Merged
Minify HTML & CSS #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview a52770e has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1351.surge.sh 🕐 Build time: 100.126s
🤖 By surge-preview |
jonaharagon
added a commit
that referenced
this pull request
May 28, 2022
jonaharagon
force-pushed
the
jonaharagon/minify
branch
from
fdb6557 to
d58d0cb
Compare
ghost
reviewed
May 28, 2022
mkdocs.yml
Outdated
| remove_comments: true | ||
| minify_css: true | ||
| css_files: | ||
| - assets/stylesheets/extra.css |
There was a problem hiding this comment.
Suggested change
| - assets/stylesheets/extra.css | |
| - assets/stylesheets/extra.css | |
| - overrides/home.css |
There was a problem hiding this comment.
Minifying this file breaks the homepage for some reason because of sprymix/csscompressor#9.
jonaharagon
added a commit
that referenced
this pull request
May 28, 2022
jonaharagon
force-pushed
the
jonaharagon/minify
branch
from
d58d0cb to
47b1c0a
Compare
jonaharagon
added a commit
that referenced
this pull request
May 28, 2022
jonaharagon
force-pushed
the
jonaharagon/minify
branch
from
47b1c0a to
26acb80
Compare
ghost
added
the
dngray
pushed a commit
that referenced
this pull request
May 29, 2022
Signed-off-by: Daniel Gray <[email protected]>
dngray
force-pushed
the
jonaharagon/minify
branch
from
26acb80 to
a539bc8
Compare
dngray
previously requested changes
May 29, 2022
|
Oh, that is the same issue we had with minifying the homepage CSS. I don't think we'll be able to minify CSS in this PR then, only HTML. I'll push a change later. |
jonaharagon
added a commit
that referenced
this pull request
May 29, 2022
Signed-off-by: Daniel Gray <[email protected]>
jonaharagon
force-pushed
the
jonaharagon/minify
branch
from
a539bc8 to
a6973b5
Compare
Signed-off-by: Daniel Gray <[email protected]>
dngray
force-pushed
the
jonaharagon/minify
branch
from
a6973b5 to
a52770e
Compare
dngray
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1343