Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miri to github ci #72

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Conversation

000wan
Copy link
Contributor

@000wan 000wan commented Sep 27, 2023

Summary

It resolves #45.
I don't know the exact reason but running tests via miri is very slow, so I've reduce test input sizes.

Test with miri runs for clmul and matrix-transpose packages.
It runs for both platforms x86_64 and aarch64.
It takes 3 mins in my fork repo.

References

https://github.com/rust-lang/miri
my ci results: 000wan#1

@000wan 000wan changed the title [WIP] Add miri to github ci Add miri to github ci Sep 27, 2023
@000wan 000wan changed the title Add miri to github ci [WIP] Add miri to github ci Sep 27, 2023
@000wan 000wan changed the title [WIP] Add miri to github ci Add miri to github ci Oct 2, 2023
@000wan
Copy link
Contributor Author

000wan commented Oct 2, 2023

Ready for review! @sinui0

Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@sinui0 sinui0 merged commit 5f07a24 into privacy-scaling-explorations:dev Oct 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add miri tests to CI
2 participants