Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI-tests with and without "simd-transpose" #33

Open
heeckhau opened this issue Jul 18, 2023 · 3 comments · May be fixed by #35
Open

Run CI-tests with and without "simd-transpose" #33

heeckhau opened this issue Jul 18, 2023 · 3 comments · May be fixed by #35
Assignees
@heeckhau
Labels
ci Continuous Integration/GitHub builds enhancement New feature or request

Comments

@heeckhau
Copy link
Collaborator

heeckhau commented Jul 18, 2023 •
edited
Loading

The CI tests currently only run with "simd-transpose" disabled. We should also run the build/test with "simd-transpose" enabled.

See also #27 (review)
@heeckhau heeckhau added enhancement New feature or request ci Continuous Integration/GitHub builds labels Jul 18, 2023
@heeckhau heeckhau self-assigned this Jul 18, 2023
@heeckhau
Copy link
Collaborator Author

heeckhau commented Jul 18, 2023 •
edited
Loading

Add "force-soft" too, https://github.com/tlsnotary/mpz/blob/86f16874859a3369e878967fc2f4146411d74492/clmul/Cargo.toml#L21

@th4s
Copy link
Member

th4s commented Jul 18, 2023

My understanding was that "enabling simd-transpose referred to the feature flag of the mpz crate matrix-transpose.

Don't we run all tests with --all-features so we already test the simd version of this library. The version without this feature flag is not tested, I guess.

@heeckhau
Copy link
Collaborator Author

Don't we run all tests with --all-features so we already test the simd version of this library. The version without this feature flag is not tested, I guess.

I don't think so: we currently run:

cargo test --lib --bins --tests --examples --workspace

https://github.com/tlsnotary/mpz/blob/86f16874859a3369e878967fc2f4146411d74492/.github/workflows/rust.yml#L32C14-L32C68

@heeckhau heeckhau changed the title Rub CI-tests with and without "simd-transpose" Run CI-tests with and without "simd-transpose" Jul 18, 2023
heeckhau added a commit that referenced this issue Jul 19, 2023
@heeckhau
Run tests with optional features
9b26fd7 
#33
@heeckhau heeckhau linked a pull request Jul 19, 2023 that will close this issue
Open
@heeckhau heeckhau linked a pull request Jul 19, 2023 that will close this issue
Run tests with optional features #35
Open
heeckhau added a commit that referenced this issue Jul 19, 2023
@heeckhau
Run tests with optional features
557eac3 
#33
heeckhau added a commit that referenced this issue Aug 15, 2023
@heeckhau
Run tests with optional features
227570e 
#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heeckhau heeckhau

Labels
ci Continuous Integration/GitHub builds enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run tests with optional features privacy-scaling-explorations/mpz
2 participants
@heeckhau @th4s