fixup! fix: Improve serialization for prime fields

privacy-scaling-explorations · Sep 4, 2023 · f018c0c · f018c0c
1 parent 4217a8a
commit f018c0c
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/derive/field.rs b/src/derive/field.rs
@@ -714,12 +714,9 @@ macro_rules! serialize_deserialize_32_byte_primefield {
                 } else {
                     <[u8; 32]>::deserialize(deserializer)?
                 };
-                match Self::from_repr(bytes).into() {
-                    Some(fq) => Ok(fq),
-                    None => Err(D::Error::custom(
-                        "deserialized bytes don't encode a valid field element",
-                    )),
-                }
+                Option::from(Self::from_repr(bytes)).ok_or_else(|| {
+                    D::Error::custom("deserialized bytes don't encode a valid field element")
+                })
             }
         }
     };