Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lookup_any #8

Merged
merged 8 commits into from
Dec 1, 2021
Merged

lookup_any #8

merged 8 commits into from
Dec 1, 2021

Conversation

ashWhiteHat
Copy link

No description provided.

This was referenced Nov 18, 2021
Closed
Closed
Closed
@ChihChengLiang
Copy link

Looks like this PR depends on lots of commits in #3, is it possible to isolate just the lookup2 part without the commits from #3?

@ashWhiteHat
Copy link
Author

Hi @ChihChengLiang
I think it's impossible because this commit depends on kilic branch.
You can check diff with following 👍
https://github.com/kilic/halo2/pull/2

@kilic
Copy link

kilic commented Nov 23, 2021

Looks good to me. Upstream pairing repo is also updated with get_lower_128 method.

@ashWhiteHat ashWhiteHat mentioned this pull request Nov 25, 2021
Merged
@CPerezz
Copy link
Member

CPerezz commented Nov 29, 2021

This needs to resolve the conflicts/be rebased into main and then merged.

On that way privacy-scaling-explorations/zkevm-circuits#199 becomes unblocked.

@ashWhiteHat
Copy link
Author

I am going to fix clippy

CPerezz
CPerezz approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kilic
kilic approved these changes Nov 30, 2021
View reviewed changes
Copy link

@kilic kilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ashWhiteHat ashWhiteHat merged commit b78c39c into privacy-scaling-explorations:main Dec 1, 2021
@ChihChengLiang ChihChengLiang mentioned this pull request Dec 6, 2021
Closed
@ChihChengLiang ChihChengLiang mentioned this pull request Dec 14, 2021
Closed
kilic pushed a commit that referenced this pull request Feb 12, 2022
@str4d
Merge pull request #8 from zcash/rename
f2d7415 
Rename to Orchard
@kilic kilic mentioned this pull request Jun 21, 2022
Closed
5 tasks
@han0110 han0110 mentioned this pull request Jul 8, 2022
Merged
jonathanpwang referenced this pull request in axiom-crypto/halo2 Nov 9, 2022
@kilic
Merge pull request #8 from appliedzkp/from_bool
3721879 
Add From<bool> traitbound to FieldExt. Should clone #3
jonathanpwang referenced this pull request in axiom-crypto/halo2 Dec 21, 2022
@kilic
Merge pull request #8 from privacy-scaling-explorations/dav/fix/secp_…
278e3ee 
…serde

Fix `secp256k1` compressed serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilic kilic kilic approved these changes

@CPerezz CPerezz CPerezz approved these changes

@therealyingtong therealyingtong Awaiting requested review from therealyingtong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashWhiteHat @ChihChengLiang @kilic @CPerezz @therealyingtong