Vanishing polynomial evaluator #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilic
force-pushed
the
eval_vanishing
branch
from
ea9c2bd
to
caa6f90
Compare
iquerejeta
added a commit
to input-output-hk/halo2
that referenced
this pull request
May 8, 2024
…hk/features/x-lt-p-range-check2 Add benchmarks and docs for scalar_fits_in_base_range_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, evaluation of vanishing polynomial was calculated in very suboptimal way ie first calculating the coefficients and then evaluation at a point. Now it's the way it should be that just uses roots and evaluation point.