-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: v5 #74
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, although my Vue knowledge is limited. I left a few small suggestions.
messages/html-serialization-is-deprecated-with-prismic-rich-text.md
Outdated
Show resolved
Hide resolved
messages/html-serialization-is-deprecated-with-prismic-rich-text.md
Outdated
Show resolved
Hide resolved
useAllPrismicDocumentsByIDs, | ||
useAllPrismicDocumentsByUIDs, | ||
useAllPrismicDocumentsByTag, | ||
useAllPrismicDocumentsByEveryTag, | ||
useAllPrismicDocumentsBySomeTags, | ||
useAllPrismicDocumentsByType, | ||
useFirstPrismicDocument, | ||
usePrismicDocumentByID, | ||
usePrismicDocumentByUID, | ||
usePrismicDocuments, | ||
usePrismicDocumentsByIDs, | ||
usePrismicDocumentsByUIDs, | ||
usePrismicDocumentsByTag, | ||
usePrismicDocumentsByEveryTag, | ||
usePrismicDocumentsBySomeTags, | ||
usePrismicDocumentsByType, | ||
useSinglePrismicDocument, | ||
dangerouslyUseAllPrismicDocuments, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ #ask: Do you have an idea of how often these composables are used? Do Nuxt projects use them?
In @prismicio/react
, I plan to provide a section in the migration guide to convert them to TanStack Query in usercode. I wonder if we need to do the same for Vue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe they were never used, especially with Nuxt because they don't integrate with Nuxt's data fetching mechanism.
I was thinking about just explaining how to create your own composable should you need to, but since TanStack Query is available in Vue also (didn't know about it), I might suggest going down the same way :)
On the Nuxt's side, Nuxt's useAsyncData
is basically the TanStack equivalent.
Types of changes
Description
Breaking changes:
isomorphic-unfetch
fallback whenglobalThis.fetch
is not availablehtmlSerializer
option, userichTextSerializer
insteadimageComponent
component optionblankTargetRelAttribute
component option<SliceZone />
resolver
prop<PrismicImage />
imageComponent
propusePrismicImage
composable<PrismicLink />
target
propblankTargetRelAttribute
propnoopener noreferrer
tonorefferer
target="_blank"
ones)field
prop, use the new dedicateddocument
prop to render documents as links<PrismicText />
usePrismicText
composable<PrismicRichText />
htmlSerializer
prop, useserializer
insteadusePrismicRichText
composableserializer
propDefineComponentSliceComponentProps
type is not exported anymoreFeatures:
linkRel
option as a replacement ofblankTargetRelAttribute
<PrismicImage />
alt
andfallbackAlt
propssrcSet
by default<PrismicImage />
rel
prop now supports a function value to resolve the desired rel attribute value<PrismicRichText />
Documentation:
CONTRIBUTING.md
guideChecklist: