-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for repeatable links in models #355
base: master
Are you sure you want to change the base?
Conversation
a683942
to
00f8524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content relationship and link to media fields are included in this PR, but I thought we were only enhancing the link field. If we're allowing it on all link-link fields, let me know and I'll approve it as is.
Everything else looks good. 👍
@@ -19,5 +19,6 @@ export interface CustomTypeModelContentRelationshipField< | |||
customtypes?: readonly CustomTypeIDs[] | |||
tags?: readonly Tags[] | |||
allowText?: boolean | |||
repeat?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Are we allowing content relationships to be repeatable? I thought we weren't, but correct me if I'm wrong.
src/types/model/linkToMedia.ts
Outdated
@@ -14,5 +14,6 @@ export interface CustomTypeModelLinkToMediaField { | |||
placeholder?: string | |||
select: typeof CustomTypeModelLinkSelectType.Media | |||
allowText?: boolean | |||
repeat?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Are we allowing link to media fields to be repeatable? I thought we weren't, but correct me if I'm wrong.
@angeloashmore changes applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can merge and publish when we are ready.
Resolves: Repeatable links project
Description
The first of 3 PRs to support an array of links as well as single links. It would allow devs to not manually wrap their link in a Group. It would also allow editors to have a better experience with a dedicated UI for multiple links.
This PR handles the model changes. The model adds a new
repeat
property to define if the link field is an array or not.Other PRS:
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩