feat: remove *AsRichText helpers
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration-related helpers will be made available through a dedicated package to limit their impact on this core Prismic SDK.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #345
This is another option to #346. Only one of the two PR should be merged.
Description
This PR removes
unstable_htmlAsRichTextandunstable_markdownAsRichTexthelpers from@prismicio/client.These migration-related helpers will be made available through a dedicated package to limit their impact on this core Prismic SDK: https://github.com/prismicio/prismic-migrate (to be made public)
This is not considered a breaking change because the helpers were considered unstable and not following SemVer. In the event you were (already) using them, migrate to
@prismicio/migrate.Checklist
How to QA 1
Double-check for any remaining of the previous helpers. Some fixes on types and alike were made when adding them so I didn't simply revert to a previous commit (and we should own our mistakes)
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩