Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add limit to all getAll*() methods (fixes #233) #234

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR adds types for the limit parameter to all getAll*() methods.

Before this PR, only dangerouslyGetAll() was property typed to accept the limit param. All getAll*() methods accepted the limit param at runtime.

Fixes #233

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🐔

@codecov-commenter
Copy link

Codecov Report

Merging #234 (01a339f) into master (ba9e8ca) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master     #234      +/-   ##
===========================================
- Coverage   100.00%   99.72%   -0.28%     
===========================================
  Files           23       23              
  Lines          360      361       +1     
  Branches        67       68       +1     
===========================================
  Hits           360      360              
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/client.ts 99.51% <100.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9e8ca...01a339f. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size
dist/index.js 4.03 KB (-0.03% 🔽)
dist/index.cjs 6.87 KB (0%)

@angeloashmore angeloashmore merged commit 7d3e4c3 into master Apr 15, 2022
@angeloashmore angeloashmore deleted the aa/get-all-params branch April 15, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getAll*() methods are not typed with a limit param
2 participants