Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Resolver option in resolvePreviewURL should be optional #183

Closed
angeloashmore opened this issue Jul 6, 2021 · 1 comment
Closed

Link Resolver option in resolvePreviewURL should be optional #183

angeloashmore opened this issue Jul 6, 2021 · 1 comment
Labels
bug Something isn't working v6 Getting addressed or related to version 6 of the kit

Comments

@angeloashmore
Copy link
Member

A Link Resolver can be optional if a client uses Route Resolvers to compute URLs.

resolvePreviewURL currently requires a value for the linkResolver argument, but this should be optional.

See this @prismicio/helpers issue for related details: prismicio/prismic-helpers#21
@angeloashmore angeloashmore added bug Something isn't working v6 Getting addressed or related to version 6 of the kit labels Jul 6, 2021
angeloashmore added a commit that referenced this issue Jul 8, 2021
@angeloashmore
fix: allow optional Link Resolver in resolvePreviewURL
4321921 
Closes #183
@angeloashmore
Copy link
Member Author

angeloashmore commented Jul 8, 2021 •
edited
Loading

Fixed in 4321921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v6 Getting addressed or related to version 6 of the kit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angeloashmore