Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

feat: upgrade to updated Gatsby plugins + reorganize #13

Merged
merged 15 commits into from
Aug 6, 2021

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented May 18, 2021

Important: This PR should remain a draft until gatsby-source-prismic V4 and gatsby-plugin-prismic-previews V4 is published.

This PR integrates the alpha gatsby-source-prismic V4 and gatsby-plugin-prismic-previews V4 plugins. It also reorganizes the project to be consistent with the updated prismicio/gatsby-getting-started-tutorial repository.

  • Update all dependencies
  • Add Prettier to automatically format files (npm run format will reformat again)
  • Use a leaner ESLint configuration (w/o Prettier)
  • Move global CSS imports to gatsby-browser.js and gatsby-ssr.js
  • Move Slices to src/slices
  • Write Slice fragments within individual Slice files
  • Use gatsby-plugin-image for all images

Further rearchitecting can be done with the SliceZone component pending further discussion here: prismicio/prismic-react#86

gatsby-plugin-image image support can be integrated after the following upstream issue is resolved: imgix/gatsby#122

@angeloashmore angeloashmore marked this pull request as ready for review July 27, 2021 01:33
@angeloashmore
Copy link
Member Author

This is ready to review now. The PR contains gatsby-image-plugin and the latest Gatsby + Prismic plugins.

src/components/GatsbyLink.js Show resolved Hide resolved
src/components/LanguageSwitcher.js Show resolved Hide resolved
src/components/LanguageSwitcher.js Show resolved Hide resolved
src/components/TopMenu.js Show resolved Hide resolved
src/pages/preview.js Show resolved Hide resolved
@angeloashmore
Copy link
Member Author

Thanks @faresd, I replied to your comments. Happy to discuss further if needed 👍. Otherwise the PR is ready to merge.

@pvpg pvpg merged commit f6c4042 into prismicio:master Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing URL parameters are removed
3 participants