This repository has been archived by the owner on May 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
feat: upgrade to updated Gatsby plugins + reorganize #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-multi-language-site into aa/gatsby-plugins-v4
This is ready to review now. The PR contains |
faresd
suggested changes
Aug 4, 2021
Thanks @faresd, I replied to your comments. Happy to discuss further if needed 👍. Otherwise the PR is ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the alpha
gatsby-source-prismic
V4 andgatsby-plugin-prismic-previews
V4 plugins. It also reorganizes the project to be consistent with the updatedprismicio/gatsby-getting-started-tutorial
repository.npm run format
will reformat again)gatsby-browser.js
andgatsby-ssr.js
src/slices
Further rearchitecting can be done with the
SliceZone
component pending further discussion here: prismicio/prismic-react#86gatsby-plugin-image image support can be integrated after the following upstream issue is resolved: imgix/gatsby#122