fix (#152): remove last new line from rich text blocks #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you see any problem with the change or the updated tests @gsteel? |
gsteel
suggested changes
Nov 21, 2022
|
I'd say this is good to be merged and released in |
|
The patch is fine now, but I struggle to see why the trailing \n is a problem in the first place. One of the problems of mixing formatting and output with these value objects is that you'll always have to be tweaking them to satisfy someones preference as to what the output should be. Standalone serializers are much easier to reason about and test and of course much more easily replaced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve Issue #152
As mentioned by @cloakedninjas it does not make sense to have a trailing
\non the last block inRichText::asText().I implemented a solution like the one mentioned in the issue and updated and extended the Tests for the
asTextfunction.