Fix todo panic #309
Open
Fix todo panic #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the Tiberius repository is no longer active. Is it possible for this PR to be merged? |
|
Not with failing tests, of course. Get them passing - and we can consider. |
|
@janpio I've reviewed the tests, but the test failures are not caused by this PR. https://github.com/wyhaya/tiberius/actions/runs/7072461970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
Unimplementedto theErrorenum to indicate something that is not implemented, in place oftodo!in the code.todo!causes an error in the programme and it is very difficult to catch it, the reason for submitting this PR is that I did encounter it and I couldn't do anything about it, it would just interrupt the execution of the programme.I know this is not good practice, but it can serve as a transition period. Until we fix all the todo, then remove it!
Thanks, tiberius