ci: build extension for each PR #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
|
Isn't committing to the branch a bad idea regarding merge conflicts and pushing from and un-updated localhost? I thought it would be enough to upload as an artifact to GH Actions and link to that. |
|
The commits are made on a specific branch https://github.com/prisma/language-tools/tree/artifacts/pull-request-artifacts So should be safe from merge conflicts, but we might need to force delete and clean it up once in a while if it takes too much space. The upload artifact thing is a no go, it's very hard to get a URL to it and expires after 90days. (uploading to the action run) The other alternative is to create a release and add the artifact there. |
|
Ahh, I did not pick up that the commit was on another branch. Neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1005