VSCode plugin formatting no longer uses editor tabSize configuration when indenting blocks

[evdhiggins]

Bug description

Prior to v3.6, the VSCode extension would indent blocks with a tab size that would take into consideration editor / user settings.

How to reproduce

Using v3.6

1. Add a non-2 tabsize configuration to settings.json

     "[prisma]": {
       "editor.defaultFormatter": "Prisma.prisma",
       "editor.tabSize": 4,
     },

2. Format the a prisma schema using VSCode
3. The blocks will be formatted with a tab size of 2, ignoring the VSCode tabSize configuration

Expected behavior

The formatted code's block indention would match the tab size specified in the user / editor settings.

Using v3.5

1. Add a non-2 tabsize configuration to settings.json

     "[prisma]": {
       "editor.defaultFormatter": "Prisma.prisma",
       "editor.tabSize": 4,
     },

2. Format the a prisma schema using VSCode
3. The blocks will be formatted with a tab size of 4, honoring the VSCode tabSize configuration

Prisma information

N/A

Environment & setup

• Editor: VSCode
• Editor version: 1.62.3
• Extension version: 3.6

[pantharshit00]

I can confirm this as a regression.

Note for anyone else on the team: Make sure to use tabs for indentation instead of spaces when you try to reproduce this. You can find that setting on bottom right hand of the editor.

[Jolg42]

I could reproduce too and found the issue, when we switched to wasm we didn't implement passing the identSize to prisma-fmt see:
https://github.com/prisma/language-tools/pull/950/files#diff-cb7aa19eb853bb2d86ec84a097509268d237443aa9fb220ab533bea42d4d89ceL10-R9

[janpio]

Right now the API only has 1 input, the schema string: https://github.com/prisma/prisma-fmt-wasm/blob/2cdafcb802f3cc5c6fad1479c87307670de7b744/src/lib.rs#L4-L6

[tomhoule]

Opened prisma/prisma-engines#2538 to fix this.

[rujorgensen]

Is this fixed in v. 3.7.0? I seem to still be having this issue 🤔.

[janpio]

No, it will be fixed in 3.8.0. You can try it out using the Prisma - Insider extension from the marketplace already.