Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove duplication in shared client extensions pages #5272

Merged
merged 17 commits into from
Nov 23, 2023
Merged

docs: remove duplication in shared client extensions pages #5272

merged 17 commits into from
Nov 23, 2023

Conversation

ruheni
Copy link
Contributor

@ruheni ruheni commented Sep 4, 2023

  • Link out to query extension docs
  • Remove redundant information

@vercel
Copy link

vercel bot commented Sep 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 4:56pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@ruheni ruheni requested review from janpio and jharrell September 4, 2023 14:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

janpio
janpio reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://prisma-company.slack.com/archives/C043X6JBND6/p1693838821507319?thread_ts=1691704235.991279&cid=C043X6JBND6 and following

@ruheni ruheni requested a review from janpio September 5, 2023 08:20
@janpio @jharrell @ruheni
Update 140-shared-extensions.mdx (#5277)
d3769ad 
Co-authored-by: Jon Harrell <[email protected]>
Co-authored-by: Alex Ruheni <[email protected]>
nikolasburk
nikolasburk reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me at first sight! anything we still need to fix here or is this one ready to merge?

@nikolasburk nikolasburk self-requested a review November 20, 2023 11:44
@janpio janpio merged commit 0c21eba into main Nov 23, 2023
5 of 6 checks passed
@janpio janpio deleted the shared-extensions-improvements branch November 23, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@nikolasburk nikolasburk nikolasburk approved these changes

@jharrell jharrell Awaiting requested review from jharrell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruheni @janpio @nikolasburk @jharrell