repl: Tab complete when useGlobal is false

Fixes nodejs#7353
princejwesley · Jun 21, 2016 · 9c69364 · 9c69364
1 parent 6be73fe
commit 9c69364
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/repl.js b/lib/repl.js
@@ -585,7 +585,15 @@ REPLServer.prototype.createContext = function() {
     context = global;
   } else {
     context = vm.createContext();
-    for (var i in global) context[i] = global[i];
+    // #7353 - tab complete returns fewer results
+    context.global = global;
+    vm.runInContext(`
+      (function() {
+        for (let name of Object.getOwnPropertyNames(global)) {
+          this[name] = this[name];
+        }
+      })()
+    `, context);
     context.console = new Console(this.outputStream);
     context.global = context;
     context.global.global = context;

diff --git a/test/parallel/test-repl-tab-complete.js b/test/parallel/test-repl-tab-complete.js
@@ -260,3 +260,14 @@ putIn.run(['.clear']);
 testMe.complete('var log = console.lo', common.mustCall((error, data) => {
   assert.deepStrictEqual(data, [['console.log'], 'console.lo']);
 }));
+
+var testNonGlobal = repl.start({
+  input: putIn,
+  output: putIn,
+  useGlobal: false
+});
+
+testNonGlobal.complete('I', common.mustCall((error, data) => {
+  assert.deepStrictEqual(data, [['Infinity', '', 'Int16Array', 'Int32Array',
+                                 'Int8Array', 'Intl'], 'I']);
+}));