-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: redistribute funds from single genesis address #465
Conversation
b24686f
to
608cfa7
Compare
cast send \ | ||
--keystore "${KEYSTORE_FILE}" \ | ||
--password "${KEYSTORE_PASSWORD}" \ | ||
--priority-gas-price 2000000000 \ | ||
--gas-price 5000000000 \ | ||
--value 1000ether \ | ||
--value 10ether \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mev-commit contract deployer can no longer send unaccounted for ether to various accounts. All usable eth on the mev-commit chain (excluding balance given to allocator contract) must have an equivalent amount locked in the L1 gateway contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funders are only used in testnet/devnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the current code to move quickly, but ideally we eventually have constant config and test bidders/providers bridge their eth from mock l1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 10 eth is being bridged from the mock L1 ? What code does that happen from?
47e7669
to
27a53c9
Compare
cast send \ | ||
--keystore "${KEYSTORE_FILE}" \ | ||
--password "${KEYSTORE_PASSWORD}" \ | ||
--priority-gas-price 2000000000 \ | ||
--gas-price 5000000000 \ | ||
--value 1000ether \ | ||
--value 10ether \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 10 eth is being bridged from the mock L1 ? What code does that happen from?
Describe your changes
Redistributes funds from single genesis address
Checklist before requesting a review