Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redistribute funds from single genesis address #465

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Conversation

mrekucci
Copy link
Collaborator

@mrekucci mrekucci commented Nov 4, 2024

Describe your changes

Redistributes funds from single genesis address

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@mrekucci mrekucci force-pushed the allocations branch 2 times, most recently from b24686f to 608cfa7 Compare November 5, 2024 11:50
@mrekucci mrekucci marked this pull request as ready for review November 5, 2024 12:20
contracts/scripts/core/DeployCore.s.sol Outdated Show resolved Hide resolved
contracts/scripts/core/DeployCore.s.sol Outdated Show resolved Hide resolved
cast send \
--keystore "${KEYSTORE_FILE}" \
--password "${KEYSTORE_PASSWORD}" \
--priority-gas-price 2000000000 \
--gas-price 5000000000 \
--value 1000ether \
--value 10ether \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mev-commit contract deployer can no longer send unaccounted for ether to various accounts. All usable eth on the mev-commit chain (excluding balance given to allocator contract) must have an equivalent amount locked in the L1 gateway contract

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funders are only used in testnet/devnet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep the current code to move quickly, but ideally we eventually have constant config and test bidders/providers bridge their eth from mock l1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 10 eth is being bridged from the mock L1 ? What code does that happen from?

@mrekucci mrekucci force-pushed the allocations branch 5 times, most recently from 47e7669 to 27a53c9 Compare November 6, 2024 15:19
contracts/scripts/core/DeployCore.s.sol Show resolved Hide resolved
cast send \
--keystore "${KEYSTORE_FILE}" \
--password "${KEYSTORE_PASSWORD}" \
--priority-gas-price 2000000000 \
--gas-price 5000000000 \
--value 1000ether \
--value 10ether \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 10 eth is being bridged from the mock L1 ? What code does that happen from?

@mrekucci mrekucci merged commit 419e63f into main Nov 7, 2024
6 checks passed
@mrekucci mrekucci deleted the allocations branch November 7, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants