fix: fixing lint

cl/ethclient/metrics.go

@@ -35,7 +35,3 @@ func latency(chain string, endpoint string) func() {
 func incError(chain, endpoint string) {
 	errorCount.WithLabelValues(chain, endpoint).Inc()
 }
-
-func spanName(endpoint string) string {
-	return "ethclient/" + endpoint
-}

cl/redisapp/blockbuilder/blockbuilder.go

@@ -18,7 +18,6 @@ import (
 	"github.com/primev/mev-commit/cl/redisapp/types"
 	"github.com/primev/mev-commit/cl/redisapp/util"
 	"github.com/vmihailenco/msgpack/v5"
-	"golang.org/x/exp/rand"
 )
 
 const maxAttempts = 3
@@ -321,21 +320,6 @@ func isSyncing(status engine.PayloadStatusV1) bool {
 	return status.Status == engine.SYNCING || status.Status == engine.ACCEPTED
 }
 
-// temp function for testing
-func sometimesFails() error {
-	rand.Seed(uint64(time.Now().UnixNano()))
-
-	chance := rand.Intn(5) // 0, 1, 2, 3, 4
-
-	if chance == 0 {
-		// Fail 1 out of 5 times (when chance == 0)
-		return errors.New("failed: 1 in 5 chance")
-	}
-
-	// Otherwise succeed
-	return nil
-}
-
 func (bb *BlockBuilder) FinalizeBlock(ctx context.Context, payloadIDStr, executionPayloadStr, msgID string) error {
 	if payloadIDStr == "" || executionPayloadStr == "" {
 		return errors.New("PayloadID or ExecutionPayload is missing in build state")

cl/redisapp/leaderfollower/leaderfollower.go

@@ -162,7 +162,11 @@ func (lfm *LeaderFollowerManager) leaderWork(ctx context.Context) error {
 	// if has messages to process, return to wait for the signal to be a leader
 	if isHaveMessagesToProcess {
 		lfm.logger.Info("Leader: State is not synchronized, waiting for follower to catch up")
-		lfm.leaderProc.Stop()
+		err := lfm.leaderProc.Stop()
+		if err != nil {
+			lfm.logger.Error("Leader: Failed to stop leader election", "error", err)
+			return err
+		}
 		return nil
 	}
 

cl/redisapp/rapp.go

@@ -96,6 +96,9 @@ func (app *MevCommitChain) Stop() {
 	// Cancel the context to signal all goroutines to stop
 	app.cancel()
 	app.stateManager.Stop()
-	app.lfm.WaitForGoroutinesToStop()
+	err := app.lfm.WaitForGoroutinesToStop()
+	if err != nil {
+		app.logger.Error("Error waiting for goroutines to stop", "error", err)
+	}
 	app.logger.Info("MevCommitChain stopped gracefully")
 }