fix: Violation Of CEI Pattern In FeePayOut Allows For Reentrancy, 443

primev · Oct 24, 2024 · 117353e · 117353e
1 parent ce3ce6f
commit 117353e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/contracts/contracts/utils/FeePayout.sol b/contracts/contracts/utils/FeePayout.sol
@@ -35,10 +35,10 @@ library FeePayout {
     /// @param tracker The FeePayout.Tracker struct
     function transferToRecipient(Tracker storage tracker) internal {
         uint256 amountToPay = tracker.accumulatedAmount;
-        (bool success, ) = payable(tracker.recipient).call{value: amountToPay}("");
-        require(success, TransferToRecipientFailed());
         tracker.accumulatedAmount = 0;
         tracker.lastPayoutBlock = block.number;
+        (bool success, ) = payable(tracker.recipient).call{value: amountToPay}("");
+        require(success, TransferToRecipientFailed());
         emit FeeTransfer(amountToPay, tracker.recipient);
     }