Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove large size options from SegmentedControl #2551

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jonrohan
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Closes https://github.com/github/primer/issues/3018

This removes the size: :large option from the segmented control. I looked at all uses of this component and none used :large

Integration

No, but a quick double check that a size :large didn't sneak in before merging.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jonrohan jonrohan requested a review from a team as a code owner January 31, 2024 18:13
@jonrohan jonrohan requested review from a team, langermank and camertron January 31, 2024 18:13
Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: 16f9eaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonrohan jonrohan enabled auto-merge (squash) January 31, 2024 18:15
@jonrohan jonrohan merged commit 5340243 into main Jan 31, 2024
29 of 30 checks passed
@jonrohan jonrohan deleted the remove_large_size_from_segmented_control branch January 31, 2024 18:22
@primer primer bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants