Remove animations on actionlist checkmark

[keithamus]

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Checkmarks are animated when they get selected/deselected, but also the way CSS animations work, the animation is also run whenever the element moves from display:none to a display where it is laid out.

This means whenever the menu is opened all the checkboxes animate in, which looks... weird.

Screenshots

a.video.showing.the.menu.being.opened.and.closed.where.the.checkmarks.animate.in.each.time.mp4

Integration

List the issues that this change affects.

A user pointed this out on a public forum: https://ruby.social/@joeldrapper/111796664357341563

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I delete the animation

Anything you want to highlight for special attention from reviewers?

Accessibility

• Fixes axe scan violation - This change fixes an existing axe scan violation.
• No new axe scan violation - This change does not introduce any new axe scan violations.
• New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 36985fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[langermank]

@keithamus is there a way we can maintain the checkmark animation generally, but for this specific scenario (a menu opens that always has things checked) remove it? I'd love to pair with you on this before we completely remove it.

[keithamus]

I think the solution would be to add a class to the button or checkbox that is active once the checkbox is checked, and remains applied for the duration of the animation (or longer), and apply the animation to that class.

[jonrohan]

🤘🏻

[langermank]

I just wanna say I don't think its the animations fault 😆 I think its a nice animation. And something weird is happening with the menu. But agree snappy is good and you'll rarely see the animation since most menus close on selection.

So long old friend 👋