Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tracking #2289

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Release Tracking #2289

merged 1 commit into from
Oct 19, 2023

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Oct 18, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

  • #2284 374d10fd Thanks @langermank! - Update tooltip design

    • Removes caret
    • Decrease offset
    • Remove animation delay
    • Use v8 color tokens
  • #2293 d7eafca0 Thanks @camertron! - Fix multi-select behavior when ActionMenus are embedded in dialogs

  • #2291 725bbd95 Thanks @camertron! - Allow ActionMenu items to submit multiple values on form submission; fix keyboard handling for submit items

Patch Changes

  • #2286 02e7f785 Thanks @langermank! - fix SegmentedControl alignment issues

  • #2288 caf09967 Thanks @TylerJDev! - Fixes issue where sometimes a dialog cannot be closed if another is open

  • #2292 46e3ff02 Thanks @jonrohan! - Fix ActionBar issue where left and end key don't loop around to end of the action bar items.

  • #2290 f33eed35 Thanks @jonrohan! - Bug fix: Respect autofocus attributes inside of a Dialog when opening a modal-dialog. When the dialog was opening before it was always focusing the first focusable element which was always the close button.

@primer primer bot requested review from a team and camertron October 18, 2023 02:33
@primer primer bot temporarily deployed to preview October 18, 2023 02:34 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Lookbook opens in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate: npm i -w ./npm-workspaces/primer/ @primer/view-components@next
    • Update primer_view_components gem: script/vendor-gem https://github.com/primer/view_components.git -r changeset-release/main
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@primer primer bot temporarily deployed to preview October 18, 2023 19:57 Inactive
@primer primer bot temporarily deployed to preview October 18, 2023 21:14 Inactive
@primer primer bot temporarily deployed to preview October 18, 2023 22:33 Inactive
@primer primer bot temporarily deployed to preview October 18, 2023 22:58 Inactive
@camertron
Copy link
Contributor

Dotcom integration PR (staff-only): https://github.com/github/github/pull/293912

@primer primer bot temporarily deployed to preview October 19, 2023 21:15 Inactive
@primer primer bot force-pushed the changeset-release/main branch 2 times, most recently from a8718dd to 3de2962 Compare October 19, 2023 21:58
@primer primer bot force-pushed the changeset-release/main branch 4 times, most recently from 1887fe5 to 9ee2807 Compare October 19, 2023 21:59
@camertron camertron merged commit 683d931 into main Oct 19, 2023
27 checks passed
@camertron camertron deleted the changeset-release/main branch October 19, 2023 22:30
@camertron camertron temporarily deployed to preview October 19, 2023 22:30 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants