Skip to content

Commit

Permalink
Fix a few issues with the SelectPanel docs (#3007)
Browse files Browse the repository at this point in the history
  • Loading branch information
camertron authored Aug 15, 2024
1 parent 9cb6ff2 commit f2afa9e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/components/primer/alpha/select_panel.rb
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ module Alpha
#
# ```erb
# <% builder = ActionView::Helpers::FormBuilder.new(
# "address", # the name of the model, used to wrap input names, eg 'address[country_code]'
# "address", # the name of the model, used to wrap input names, eg 'address[country]'
# nil, # object (eg. the Address instance, which we can omit)
# self, # template
# {} # options
Expand All @@ -168,7 +168,7 @@ module Alpha
# form_arguments: { builder: builder, name: "country" }
# )) do |list| %>
# <% countries.each do |country| %>
# <% menu.with_item(label: country.name, data: { value: country.code }) %>
# <% menu.with_item(label: country.name, content_arguments: { data: { value: country.code } }) %>
# <% end %>
# <% end %>
# ```
Expand Down Expand Up @@ -326,7 +326,7 @@ def initialize(**system_arguments)
# @param title [String] The title that appears at the top of the panel.
# @param id [String] The unique ID of the panel.
# @param size [Symbol] The size of the panel. <%= one_of(Primer::Alpha::Overlay::SIZE_OPTIONS) %>
# @param select_variant [Symbol] <%= one_of(Primer::Alpha::ActionList::SELECT_VARIANT_OPTIONS) %>
# @param select_variant [Symbol] <%= one_of(Primer::Alpha::SelectPanel::SELECT_VARIANT_OPTIONS) %>
# @param fetch_strategy [Symbol] <%= one_of(Primer::Alpha::SelectPanel::FETCH_STRATEGIES) %>
# @param no_results_label [String] The label to display when no results are found.
# @param preload [Boolean] Whether to preload search results when the page loads. If this option is false, results are loaded when the panel is opened.
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"lint:eslint": "eslint 'app/components/**/*.ts'",
"lint:eslint:fix": "eslint 'app/components/**/*.ts' --fix",
"changeset:version": "changeset version && script/version",
"build": "script/build-assets",
"build:js": "script/build-assets js",
"build:css": "script/build-assets css"
},
Expand Down

0 comments on commit f2afa9e

Please sign in to comment.