Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tooltip e2e tests and add sx prop story #5248

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Refactor Tooltip e2e tests and add sx prop story #5248

merged 2 commits into from
Nov 7, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 7, 2024

Prelude to #5228

This adds tests for sxProp usage and refactors the e2e story tests

@jonrohan jonrohan requested a review from a team as a code owner November 7, 2024 20:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ffbd262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan added skip changeset This change does not need a changelog update snapshots labels Nov 7, 2024
@github-actions github-actions bot added the staff Author is a staff member label Nov 7, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5248 November 7, 2024 20:21 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.4 KB (0%)
packages/react/dist/browser.umd.js 98.67 KB (0%)

@primer primer bot requested a review from a team as a code owner November 7, 2024 20:28
@primer primer bot requested a review from tbenning November 7, 2024 20:28
@jonrohan jonrohan added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit f743717 Nov 7, 2024
43 checks passed
@jonrohan jonrohan deleted the tooltip_sx_prop_dev_stories branch November 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup broccolinisoup is a code owner automatically assigned from primer/engineer-reviewers

@tbenning tbenning Awaiting requested review from tbenning tbenning is a code owner automatically assigned from primer/design-reviewers

@joshblack joshblack Awaiting requested review from joshblack

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @langermank