-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextInput): Update TextInput to use data attributes for styling #5242
Open
hussam-i-am
wants to merge
14
commits into
main
Choose a base branch
from
hussam-i-am/text-input-data-attrs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,221
−2,732
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
669d8f9
chore(TextInput): Update TextInput to use data attributes for styling
hussam-i-am 19d0b08
remove variant functions
hussam-i-am 51aed91
add data attrs
hussam-i-am b475780
Merge branch 'main' of https://github.com/primer/react into hussam-i-…
hussam-i-am e3617ee
update jest snapshots
hussam-i-am 6a241ce
changeset
hussam-i-am 6db3a71
add width to block
hussam-i-am 189a565
add higher specificity to passing in sx
hussam-i-am e902102
update snapshots
hussam-i-am d99cd58
revert success border color
hussam-i-am 0a463f2
Merge branch 'main' into hussam-i-am/text-input-data-attrs
hussam-i-am fef5246
Merge branch 'main' into hussam-i-am/text-input-data-attrs
hussam-i-am 05973c0
Merge branch 'main' into hussam-i-am/text-input-data-attrs
hussam-i-am 779c1f3
Merge branch 'main' into hussam-i-am/text-input-data-attrs
hussam-i-am File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@primer/react": minor | ||
--- | ||
|
||
Convert TextInput to use data attributes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update so that variables accurately reflect what is being tests.