Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking (37.4.0) #5239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Release tracking (37.4.0) #5239

wants to merge 1 commit into from

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Nov 6, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

Patch Changes

  • #5230 dce754b Thanks @siddharthkp! - SelectPanel: (Implementation detail, should have no changes for users) Replace AnchoredOverlay with Overlay and useAnchoredPosition

  • #5236 2e5c601 Thanks @jonrohan! - Update Spinner component to correctly use the size prop when both sx and size are provided

@primer primer bot requested a review from a team as a code owner November 6, 2024 14:51
@primer primer bot requested a review from siddharthkp November 6, 2024 14:51
Copy link
Contributor

github-actions bot commented Nov 6, 2024

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5239 November 6, 2024 14:53 Inactive
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.56 KB (0%)
packages/react/dist/browser.umd.js 99 KB (0%)

@siddharthkp
Copy link
Member

Leaving a note for myself:

Integration tests are passing with 3 PRs in the changelog, will check again today and merge:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant