Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: Check for integration result comment #5233

Merged
merged 26 commits into from
Nov 6, 2024
Merged

workflow: Check for integration result comment #5233

merged 26 commits into from
Nov 6, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 5, 2024 •
edited
Loading

Add workflow to look at the integration-tests comment on pull requests and update labels.

  • This workflow is trigged on issue_comment: [created, edited]
  • It checks if there is a comment from integration tests workflow in github/github
  • Based on the message format (🟢 or 🔴), it will add integration-tests: passing or integration-tests: failing label
  • We can, in the future, choose to fail CI if the comment from integration-tests says failing. Don't want to do that just yet though

Example:

comment on PR with text: github-actions bot added integration-tests: passing and removed integration-tests: recommended labels 17 minutes ago

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the staff Author is a staff member label Nov 5, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 5, 2024 16:41 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.58 KB (0%)
packages/react/dist/browser.umd.js 98.94 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 5, 2024 16:46 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 5, 2024 16:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 5, 2024 16:58 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350056

@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 5, 2024 17:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 5, 2024 17:17 Inactive
@primer-integration
Copy link

primer-integration bot commented Nov 5, 2024 •
edited
Loading

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Nov 5, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 6, 2024 15:40 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 6, 2024
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 6, 2024 15:47 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 6, 2024 15:49 Inactive
@siddharthkp siddharthkp changed the title Create check-for-integration-result.yml workflow: Check for integration result comment Nov 6, 2024
@siddharthkp siddharthkp self-assigned this Nov 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5233 November 6, 2024 15:57 Inactive
@siddharthkp siddharthkp marked this pull request as ready for review November 6, 2024 15:58
@siddharthkp siddharthkp requested a review from a team as a code owner November 6, 2024 15:58
francinelucca
francinelucca approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it ✨

@siddharthkp siddharthkp added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit e1993f1 Nov 6, 2024
44 checks passed
@siddharthkp siddharthkp deleted the convert-integration-comment-to-status branch November 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

Assignees

@siddharthkp siddharthkp

Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @francinelucca