feat(VisuallyHidden): Convert VisuallyHidden to CSS module behind feature flag

[randall-krauskopf]

Related To: https://github.com/github/primer/issues/4368
Closes: https://github.com/github/primer/issues/4368

Changelog

Changed

Convert VisuallyHidden component to css module behind feature flag

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

[changeset-bot]

🦋 Changeset detected

Latest commit: 04dd885

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	97.24 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js	97.57 KB (+0.07% 🔺)

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349259

[primer-integration]

🟢 golden-jobs completed with status success.

[joshblack]

Looks great! Just left a comment in case it's helpful info. I think you're totally good to go though since integration checks passed 🔥

[joshblack]

Just wanted to share in case it was helpful (and feel free to ignore me if this is obvious 😂), when migrating styled components that are exported two helpful things I've found to double-check check are the as prop and ref support.

When we update these kinds of components these don't come along and they may be used downstream. It's hard to tell if these are breaking changes or not so I think we've been evaluating it by seeing if they are used this way in dotcom when updating.

Thankfully the integration tests tend to do a good job of double-checking this, also feel free to use Primer Query (e.g. this link, if you need to login then you'll have to click the link again since query params aren't persisted 😅)

[randall-krauskopf]

Thank you for the reminder. I'll definitely add this to my routine on components moving forward!