-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel: Implement full variant for narrow screens #5170
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
🟢 golden-jobs completed with status |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349615 |
…overlay styles are set
Closes https://github.com/github/primer/issues/4109
Changelog
New
full-variant
to the current SelectPanel. This is not a prop/option to choose; it is a default behaviour when the screen is narrow to accommodate more content due to accessibility concerns.Changed
StyledOverlay
instead ofAnchoredOverlay
to accomodate both anchored and full-screen styles via css.Removed
Rollout strategy
Testing & Reviewing
You can test this behaviour on any story when the screen is narrow.