Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectPanel: Implement full variant for narrow screens #5170

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Oct 23, 2024

Closes https://github.com/github/primer/issues/4109

Changelog

New

  • Introducing full-variant to the current SelectPanel. This is not a prop/option to choose; it is a default behaviour when the screen is narrow to accommodate more content due to accessibility concerns.
  • "Close (X)" button

Changed

  • Refactored SelectPanel to use StyledOverlay instead of AnchoredOverlay to accomodate both anchored and full-screen styles via css.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

You can test this behaviour on any story when the screen is narrow.

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: e2055fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 23, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 23, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5170 October 23, 2024 05:42 Inactive
Copy link
Contributor

github-actions bot commented Oct 23, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 99.11 KB (+0.54% 🔺)
packages/react/dist/browser.umd.js 99.42 KB (+0.54% 🔺)

@primer-integration
Copy link

primer-integration bot commented Oct 30, 2024

🟢 golden-jobs completed with status success.

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349615

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant