Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #4672 #4745

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Resolves #4672 #4745

wants to merge 5 commits into from

Conversation

cihad
Copy link
Contributor

@cihad cihad commented Jul 17, 2024

Resolves #4672

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@cihad cihad requested a review from a team as a code owner July 17, 2024 12:32
@cihad cihad requested a review from camertron July 17, 2024 12:32
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 35bf2c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cihad 👋🏻 Thanks so much for pushing this PR! The changes looks good to me. Could you please add a changeset and fill out the PR description? 🙏🏻

@TylerJDev
Copy link
Contributor

Hey @cihad! Just wanted to follow-up and see if you were still working on this PR? I see it's nearly finished, it looks like it just needs a changeset and an update to your PR description. Thank you too for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<UnderlineNav.Item /> without counter shows loading indicator
5 participants