-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove main
landmark from PageLayout.Content.
#3675
Conversation
…lopers to specify.
🦋 Changeset detectedLatest commit: d04beb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@radglob what does the splash zone of this change look like upstream? Are there any changes we need to make in dotcom before landing this? |
size-limit report 📦
|
I don't think we have any issues upstream at this point. Armagan had looked into it a bit, and the issue in dotcom was a test that was checking for a |
@radglob sweet, sounds great! Opened up: https://github.com/github/github/pull/286317 for the last round of checks but otherwise LGTM! Will leave an approval on the PR once that goes green ✅ |
Reintroducing these changes which were introduced in #3154, but were reverted.
Closes https://github.com/github/primer/issues/1586
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.