Address ToggleSwitch a11y feedback, take 2 #3433
Conversation
* Address ToggleSwitch a11y feedback * Remove unused import * Add changeset * Fix tests
🦋 Changeset detectedLatest commit: 82471b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
changed the title
size-limit report 📦
|
|
Dotcom integration PR: https://github.com/github/github/pull/277343 There seem to be no test failures, which seems weird to me? I thought it was reverted because it broke something in prod? cc @broccolinisoup |
|
@camertron First of all, it is great news that it is not failing 🎉 But I am confused too. I think I have a guess why it failed before and why it doesn't now but let me know your thoughts 🙌🏻 If we look at the logs that we made the reverting decision based on, we saw the error of 'Unable to find an accessible element with the role "switch"' and because I wonder if the We still haven't managed to merge the upgrade PR due to all of these unrelated failings, so we can't really test it in the review lab 😥 I think the results would probably be more accurate if we can test it on the new version of PRC (after merging that PR) |
|
Hey @broccolinisoup, sorry for the confusion, I made a mistake and somehow didn't bump primer/react correctly 😳 I just re-bumped it to the pre-release version and now I see test failures. Apologies! I'll get things fixed 👍 |
|
@camertron No worries, all good!! Good luck 🤞🏻 |
There was a problem hiding this comment.
Very nice!
Checked usage for component and looks safe to ship. 
|
Hi @siddharthkp! I think this PR was breaking some tests at dotcom - reference and we reverted it in the previous release. I don't think the failures are fixed yet? I don't see any new commits in the PR 🤔 |
My bad! I misread your comment above and thought now the issues are fixed 😓 I will revert the revert 😭 and copy the description from this PR Update: #3483 |
* Revert "Address ToggleSwitch a11y feedback (#3251) (#3433)" This reverts commit cd086ae. * Update generated/components.json --------- Co-authored-by: siddharthkp <[email protected]>
This PR addresses the accessibility feedback for the ToggleSwitch component, outlined in this issue: https://github.com/github/primer/issues/1867. It is a re-submission of #3251 which had to be reverted, see #3429 for details.
Namely it:
role=switchfrom the button.aria-pressedin favor ofaria-checked.Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.