fix(bundle): remove inline @github deps #2404
Conversation
🦋 Changeset detectedLatest commit: 9898d4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| external.filter(id => { | ||
| return !id.startsWith('@github') | ||
| }) | ||
| ), |
There was a problem hiding this comment.
I'm curious why this filter was added in the first place. Will removing it cause any side effects?
There was a problem hiding this comment.
Hey @pksjce! 👋
The background for the filter was to inline the ESM-only dependencies from @github in the CommonJS bundle to get that working again. This was kind of a trade-off until we moved to ESM-only and don't have to support CommonJS anymore
There was a problem hiding this comment.
As long as we are fine with ESM only, LGTM!
|
Following up on this, it seems like it may be due to the workflow publishing using The canary publishes that use |
|
This looks good to me! |
This PR updates the rollup config to not inline
@githubdependencies in CommonJS. This is due to two problems when packaging:node_modulesfolder whenlibis ignored when publishingrequire()statement within_FormattingTools.tsxis not being rewritten to the inlined dependency when enabledTo unblock 35.11, this PR reverts this change back to the existing behavior until we can resolve the two points above.