Add Noto Sans to the font stack
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe3cf0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Variables changedNo variables changed |
2 tasks
🔍 Design token changes foundView CSS variable changes- --primer-fontStack-sansSerif: -apple-system, BlinkMacSystemFont, 'Se
+ --primer-fontStack-sansSerif: -apple-system, BlinkMacSystemFont, 'Se- --primer-fontStack-system: -apple-system, BlinkMacSystemFont, 'Segoe
+ --primer-fontStack-system: -apple-system, BlinkMacSystemFont, 'Segoe |
vdepizzol
approved these changes
Nov 16, 2022
|
Hey @simurai can we merge this? |
I was gonna wait a few more days since this change shipped on dotcom just yesterday. But sure, we can also undo this PR in case issues are being reported. |
langermank
added a commit
that referenced
this pull request
Nov 17, 2022
* Add `Noto Sans` to the font stack * Create small-chicken-remain.md Co-authored-by: Katie Langerman <[email protected]>
Merged
wh0
pushed a commit
to wh0/iswas
that referenced
this pull request
Apr 8, 2023
cross reference: primer/primitives#385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds
Noto Sansto the font stack. See primer/css#2300 for more infos.List of notable changes:
Noto SanstofontStack.systemNoto SanstofontStack.sansSerifWhat should reviewers focus on?
Steps to test:
Might not be easy to test, but
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: