-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package to @primer/primitives #14
Conversation
@shawnbot I think the changes here would pretty much do it. I did have one thing I wanted to ask you about: in order to have, e.g., (Edit: another thought I had was making the main import |
A couple of thoughts:
I'm interested to hear what @emplums and @broccolini think too! |
I think I get where you're coming from. Although:
Since the files are already JSON, is there anything we would need to do at all? |
Sorry, I don't know why I imagined them as JS. So yeah, no changes needed on that front! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I agree it's nice to have the theme as a separate export and fine with having different folders for each subfolder vs adding that as a build step!
Cool, I like this as well. As I'm implementing these changes, all of the following are supported: import theme from '@primer/primitives/theme'
import colors from '@primer/primitives/colors'
import typography from '@primer/primitives/typography'
// ...
import { theme, colors, typography } from '@primer/primitives' The more I mess around with it, the more I'm in favor of exporting both |
I'm totally on board with this. +1000 to fewer contracts to maintain! |
Sweet — in that case, the README is updated and this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Let's ship this!
Co-Authored-By: Shawn Allen <[email protected]>
Wooooo!!! 🚢 it! 🎉 |
This PR implements the move away from a monorepo and consolidation under
@primer/primitives
as described in #8.@primer/primitives
package at root@primer/primitives/<module>
@primer/primitives
is published)Fixes #8