Skip to content

Commit

Permalink
Fix pvc asset redirects (#407)
Browse files Browse the repository at this point in the history
* Fix asset redirects for PVC Lookbook, which uses Vite now

* Use v4 of upload/download artifact actions
  • Loading branch information
camertron authored Nov 6, 2024
1 parent 94b6f34 commit 0dd84d8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy_staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
cp web.config public/
- name: Upload artifact for deployment job
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: node-app
path: ./public/
Expand All @@ -58,7 +58,7 @@ jobs:
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

- name: Download artifact from build job
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: node-app

Expand Down
5 changes: 5 additions & 0 deletions redirects.json
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,11 @@
"match": "^assets/(.*)",
"destination": "https://primer-lookbook.github.com/assets/{R:1}"
},
{
"name": "ViewComponents Preview assets proxy (Vite)",
"match": "^vite/assets/(.*)",
"destination": "https://primer-lookbook.github.com/vite/assets/{R:1}"
},
{
"name": "ViewComponents Lookbook assets proxy",
"match": "^lookbook-assets/(.*)",
Expand Down

0 comments on commit 0dd84d8

Please sign in to comment.