Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save sparkle-fill-16.svg #902

Merged
merged 11 commits into from
Jan 25, 2023
Merged

Save sparkle-fill-16.svg #902

merged 11 commits into from
Jan 25, 2023

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Jan 25, 2023

Adds a sparkle icon
CleanShot 2023-01-25 at 09 14 13@2x

@gavinmn gavinmn requested a review from a team as a code owner January 25, 2023 17:14
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a5470ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gavinmn gavinmn changed the title Save sparkle-32.svg Save sparkle-16.svg Jan 25, 2023
tallys
tallys approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@tallys tallys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@colebemis
Copy link
Contributor

Should this be called sparkle-fill-16 for consistency with the other filled icons?

@gavinmn gavinmn temporarily deployed to github-pages January 25, 2023 18:08 — with GitHub Actions Inactive
@gavinmn gavinmn changed the title Save sparkle-16.svg Save sparkle-fill-16.svg Jan 25, 2023
@gavinmn gavinmn merged commit 4cbc043 into main Jan 25, 2023
@gavinmn gavinmn deleted the add-sparkle branch January 25, 2023 18:54
@primer-css primer-css mentioned this pull request Jan 25, 2023
Merged
@skemex skemex mentioned this pull request May 24, 2024
Open
@soumen1102 soumen1102 mentioned this pull request Jun 20, 2024
Open
@rbragaru rbragaru mentioned this pull request Aug 14, 2024
Open
This was referenced Sep 9, 2024
Open
Merged
This was referenced Sep 10, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
This was referenced Sep 21, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallys tallys tallys approved these changes

@colebemis colebemis Awaiting requested review from colebemis colebemis is a code owner automatically assigned from primer/octicons-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavinmn @colebemis @tallys @actions-user