Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line highlighting for live code blocks #453

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

hectahertz
Copy link
Contributor

In order to emphasize a particular range of lines, this adds the highlight attribute on the live code blocks. The line highlighting will disappear when the live example is edited.

This implementation is quite simple, and we could improve on this to support highlighting multiple ranges in the future.

The approach is a bit unorthodox, as react-live does not support line highlighting yet.

Example with line highlighting enabled on a code block

@hectahertz hectahertz requested a review from siddharthkp July 14, 2022 16:29
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

⚠️ No Changeset found

Latest commit: 48b731b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hectahertz hectahertz temporarily deployed to github-pages July 14, 2022 16:32 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful, extra points for handling pristine/dirty state!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants