-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax highlighting support for ruby and erb #203
Conversation
🦋 Changeset detectedLatest commit: 5709e7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). doctocat – ./🔍 Inspect: https://vercel.com/primer/doctocat/7amR94d5iunr2ETZqBits1n8ND37 gatsby-theme-primer-example – ./🔍 Inspect: https://vercel.com/primer/gatsby-theme-primer-example/4QGkwF2EbYdxkexZynaQ8EQkUd9a |
I filed an issue in the prism repo to report the bug described in my previous comment: PrismJS/prism#2602 |
@colebemis any updates here? |
@manuelpuyol Sorry, I haven't had time to follow up on this. If you feel comfortable, feel free to take over this PR. Otherwise, I'll revisit this when I have more time. |
Dug some more and I think I found the problem FormidableLabs/prism-react-renderer#104 |
As an update, my PR FormidableLabs/prism-react-renderer#105 was merged! I'm waiting for For it to work properly we have to set up our custom PrismJS, which I did in |
@@ -0,0 +1,74 @@ | |||
export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work, @manuelpuyol! Very impressed with your debugging abilities. Thanks for pushing this over the finish line ❤️
Approved ✅ (I can't officially approve because I started the PR 😅)
This PR adds support for
ruby
anderb
syntax highlighting in code examples:Example
Before
After
Closes #200