-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing TimelineItem from .com and creating matching docs #913
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/orb2t9cwm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Let's queue it up for inclusion in 13.1.0, assuming we don't decide to move forward with 14.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonrohan it looks like this isn't being imported anywhere in the product bundle. I'm stumped as to why this actually works on the docs site, though. 🤔
Either way, it's not present in dist/primer.css
from the most recently published canary release, so let's fix that before merging.
Great catch! I think it's because the Anyways, I added the import to "product" 74d0495. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @simurai!
This PR adds the
TimelineItem
component that was recently added to github/github#120332I'm also documenting the new component on primer.style
TODO on dotcom
/cc @primer/ds-core