Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing TimelineItem from .com and creating matching docs #913

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 26, 2019

This PR adds the TimelineItem component that was recently added to github/github#120332

I'm also documenting the new component on primer.style

image

TODO on dotcom

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Sep 26, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/orb2t9cwm
🌍 Preview: https://primer-css-git-timelineitem.primer.now.sh

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Let's queue it up for inclusion in 13.1.0, assuming we don't decide to move forward with 14.0.0.

@shawnbot
Copy link
Contributor

shawnbot commented Sep 30, 2019

@jonrohan let's roll the min-width: 0 fix into this PR before merging into #911 into 13.1.0

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonrohan it looks like this isn't being imported anywhere in the product bundle. I'm stumped as to why this actually works on the docs site, though. 🤔

Either way, it's not present in dist/primer.css from the most recently published canary release, so let's fix that before merging.

@shawnbot shawnbot mentioned this pull request Oct 22, 2019
15 tasks
@shawnbot shawnbot changed the base branch from master to release-13.2.0 October 22, 2019 23:57
@simurai
Copy link
Contributor

simurai commented Oct 23, 2019

it looks like this isn't being imported anywhere in the product bundle. I'm stumped as to why this actually works on the docs site, though. 🤔

Great catch! I think it's because the TimelineItem styles get currently added to the docs through styleguide.css.

Anyways, I added the import to "product" 74d0495.

@simurai simurai requested a review from shawnbot October 23, 2019 04:37
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @simurai!

@shawnbot shawnbot merged commit 3f8775b into release-13.2.0 Oct 23, 2019
@shawnbot shawnbot deleted the timelineitem branch October 23, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants