Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 13.0.0 #887

Merged
merged 68 commits into from
Sep 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
71697d8
:fire: Remove .dropdown-menu-content
simurai Sep 6, 2019
de5e406
Update button.scss
Mar 19, 2019
13616aa
Update buttons.md
Mar 19, 2019
1c86842
npm version 13.0.0
shawnbot Sep 9, 2019
335dff2
remove npm defaults from .npmrc
shawnbot Sep 9, 2019
afd5a05
remove build directory
shawnbot Sep 10, 2019
2b3ae9d
remove now-* npm scripts
shawnbot Sep 10, 2019
5a9ebe6
disable no-console in script/
shawnbot Sep 10, 2019
398b6a3
remove styleguide path cache
shawnbot Sep 10, 2019
b2c942b
remove docs-test/exceptions.js
shawnbot Sep 10, 2019
09bab3b
docs-test/urls.js -> script/test-doc-urls.js
shawnbot Sep 10, 2019
a02dd77
nix lib/erb-to-html
shawnbot Sep 10, 2019
3e91364
rename JS scripts to *.js; lint
shawnbot Sep 10, 2019
d830495
update script paths in package.json
shawnbot Sep 10, 2019
2135b52
remove lots of unused dev dependencies!
shawnbot Sep 10, 2019
71b9992
fix bundle-size-report path
shawnbot Sep 10, 2019
eb7cc3a
rename script/check-relative-links -> .js
shawnbot Sep 10, 2019
5e55b3c
derp
shawnbot Sep 10, 2019
06ead4c
Merge pull request #890 from primer/tidy-scripts-deps
shawnbot Sep 10, 2019
f2ab893
delete .text-pending and .bg-pending
shawnbot Sep 9, 2019
df4e484
add script/test-deprecations
shawnbot Sep 10, 2019
89cb5e7
run deprecations test on release-* branches
shawnbot Sep 10, 2019
dd10c9e
rename ci workflow
shawnbot Sep 10, 2019
1caf0f0
fix workflow
shawnbot Sep 10, 2019
3ffe4df
Update ci.yml
shawnbot Sep 10, 2019
2efb3d7
re-consolidate jobs
shawnbot Sep 10, 2019
429febb
remove duplicate checkout
shawnbot Sep 10, 2019
b15b9b6
tidy up deprecation test messages
shawnbot Sep 10, 2019
d7f554e
run prepublish before testing deprecations
shawnbot Sep 10, 2019
69dd24f
improve test-deprecations messaging
shawnbot Sep 10, 2019
448e7a7
rename JS scripts to *.js; lint
shawnbot Sep 10, 2019
6869e77
update script/test-deprecations.js path
shawnbot Sep 10, 2019
27beb57
add --help screen to test-deprecations
shawnbot Sep 10, 2019
b9b0638
Removing container grid styles and docs
jonrohan Jan 25, 2019
af86d15
Removing layout test
jonrohan Jan 25, 2019
ac31c56
remove columns.scss import
shawnbot Sep 9, 2019
b2fb37c
Merge pull request #889 from primer/release-workflow
shawnbot Sep 10, 2019
ae36cbf
Merge remote-tracking branch 'origin/release-13.0.0' into remove_colu…
shawnbot Sep 10, 2019
049b110
tidy up duplicate deprecation test messages
shawnbot Sep 10, 2019
40bca3c
add .container and ::before / ::after selectors to v13 deprecations
shawnbot Sep 10, 2019
5492a3a
chore: lint deprecations.js
shawnbot Sep 10, 2019
a4e4fda
Merge pull request #736 from primer/adios-purp
shawnbot Sep 10, 2019
fbdc634
Merge pull request #662 from primer/remove_column_styles
shawnbot Sep 10, 2019
bb1d39c
add all the .btn-purple selectors to deprecations.js
shawnbot Sep 10, 2019
4a60869
Merge pull request #891 from primer/fix-purple-deprecations
shawnbot Sep 10, 2019
3a575bd
Merge remote-tracking branch 'origin/release-13.0.0' into dropdown-me…
shawnbot Sep 10, 2019
f95681f
add deprecations for .dropdown-menu-content
shawnbot Sep 10, 2019
3889f1c
Merge pull request #884 from primer/dropdown-menu-content
shawnbot Sep 10, 2019
db3b619
deps: upgrade [email protected]
shawnbot Sep 10, 2019
1a90381
nix stylelint rule primer/selector-no-utility
shawnbot Sep 10, 2019
425cbf7
delete src/layout/columns.scss
shawnbot Sep 10, 2019
394753b
Replace <menu> with <div>
simurai Sep 11, 2019
1bf780b
Add permanent transparent border
simurai Sep 11, 2019
cffac8d
Fix linter
simurai Sep 11, 2019
03c9df1
Merge pull request #892 from primer/stylelint-config-primer-8.0.0
shawnbot Sep 11, 2019
3533fe4
Merge pull request #893 from primer/select-menu-improvements
simurai Sep 12, 2019
e5c4062
v13.0.0 changelog
shawnbot Sep 12, 2019
0d81915
Update doctocat
Sep 12, 2019
4726ce2
add iframe to live preview wrapper
Sep 12, 2019
b1a9d6d
add redirect from /objects/layout -> /objects/grid
shawnbot Sep 12, 2019
3499e12
remove Layout nav item
shawnbot Sep 12, 2019
e4ce9e9
Merge pull request #895 from primer/shadow-live-preview
shawnbot Sep 12, 2019
e9a2c22
update v13.0 changelog, fix PR links
shawnbot Sep 12, 2019
5fe250d
do the redirect in now.json
shawnbot Sep 12, 2019
d39e107
restore /utilities/layout link; remove /objects/layout
shawnbot Sep 12, 2019
8d75886
move /css redirects up
shawnbot Sep 12, 2019
24903d9
redirect with trailing slash?
shawnbot Sep 12, 2019
6355e37
Merge pull request #896 from primer/redirect-layout
shawnbot Sep 12, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/push.yml → .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: "lint, test, publish"
on: [push]
name: CI
on: push
jobs:
all:
runs-on: ubuntu-latest
Expand All @@ -16,6 +16,9 @@ jobs:
run: npm --unsafe-perm test
- name: prepublish
run: script/prepublish
- name: test deprecations
if: startsWith(github.ref, 'refs/heads/release-')
run: script/test-deprecations.js
- uses: primer/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 0 additions & 2 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
save=true
save-exact=true
git-tag-version=false
3 changes: 1 addition & 2 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"stylelint-config-primer"
],
"rules": {
"primer/no-override": false,
"primer/selector-no-utility": false
"primer/no-override": false
}
}
26 changes: 26 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,29 @@
# 13.0.0

### :boom: Breaking Change
- Remove `.container`, `.columns`, `.column`, and related classes [#662](https://github.com/primer/css/pull/662)
- Remove `.btn-purple` [#736](https://github.com/primer/css/pull/736) :wave: 💜
- Remove `.text-pending` and `.bg-pending` [#888](https://github.com/primer/css/pull/888)
- Remove `.dropdown-menu-content` [#884](https://github.com/primer/css/pull/884)

### :nail_care: Polish
- Select menu improvements [#893](https://github.com/primer/css/pull/893)

### :memo: Documentation
- The layout docs, formerly available at `/css/objects/layout`, are gone and will redirect to `/css/objects/grid`.

### :house: Internal
- Add deprecations test script [#889](https://github.com/primer/css/pull/889)
- Clean up scripts and dev dependencies [#890](https://github.com/primer/css/pull/890)
- Upgrade stylelint-config-primer to v8.0.0 [#892](https://github.com/primer/css/pull/892)
- Upgrade doctocat, live code wrappers [#895](https://github.com/primer/css/pull/895)

### Committers
- [@jonrohan](https://github.com/jonrohan)
- [@shawnbot](https://github.com/shawnbot)
- [@simurai](https://github.com/simurai)
- [@sophshep](https://github.com/sophshep)

# 12.7.0

### :rocket: Enhancement
Expand Down
27 changes: 26 additions & 1 deletion deprecations.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,19 @@
const versionDeprecations = {
'13.0.0': [
{
selectors: ['.btn-purple'],
selectors: [
'.btn-purple',
'.btn-purple:focus',
'.btn-purple.focus',
'.btn-purple:hover',
'.btn-purple.hover',
'.btn-purple:active',
'.btn-purple.selected',
'[open]>.btn-purple',
'.btn-purple:disabled',
'.btn-purple.disabled',
'.btn-purple .Counter'
],
message: `Please don't make purple buttons.`
},
{
Expand All @@ -19,7 +31,12 @@ const versionDeprecations = {
},
{
selectors: [
'.container',
'.container::before',
'.container::after',
'.columns',
'.columns::before',
'.columns::after',
'.column',
'.one-third',
'.two-thirds',
Expand All @@ -34,6 +51,14 @@ const versionDeprecations = {
{
selectors: ['.centered'],
message: `You can use the "mx-auto" class to center any element.`
},
{
selectors: [
'.dropdown-menu-content',
'.dropdown.active .dropdown-menu-content',
'.dropdown-menu-content.anim-scale-in'
],
message: `The "dropdown-menu-content" class is unnecessary.`
}
]
}
Expand Down
26 changes: 0 additions & 26 deletions docs-test/exceptions.js

This file was deleted.

80 changes: 0 additions & 80 deletions docs-test/fixtures/path-cache.txt

This file was deleted.

4 changes: 2 additions & 2 deletions docs/content/components/buttons.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Use `.btn-large` to increase the padding and border radius of a button. This is

```html live
<p>
<a class="btn btn-large btn-purple" href="#url" role="button">Large link button</a>
<a class="btn btn-large" href="#url" role="button">Large link button</a>
<button class="btn btn-large" type="button">Large button button</button>
</p>
```
Expand All @@ -68,7 +68,7 @@ Use `.btn-large` with a type scale utility to transform the text to a bigger siz

```html live
<p class="f3">
<a class="btn btn-large btn-purple" href="#url" role="button">Large link button</a>
<a class="btn btn-large" href="#url" role="button">Large link button</a>
<button class="btn btn-large btn-outline-blue" type="button">Large button button</button>
</p>
```
Expand Down
Loading