Primer 10.2.0 #407
Merged
Primer 10.2.0 #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point style field to built css
automatically style first and last breadcrumb
Updates to stylelint package links/docs for new structure
Add Sass key to package.json
Increase spacing scale
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
broccolini
requested changes
Dec 18, 2017
CHANGELOG.md
Outdated
| # 10.2.0 (2017-12-11) | ||
|
|
||
| #### :rocket: Enhancement | ||
| * [#376](https://github.com/primer/primer/pull/376) Increase spacing scale. ([@gladwearefriends](https://github.com/gladwearefriends)) |
There was a problem hiding this comment.
Could you change the title to "Extend spacing scale for marketing" to make it a bit clearer?
| @@ -12,6 +11,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| :last-child .breadcrumb-item, | |||
There was a problem hiding this comment.
This change removes the forward slash off of every breadcrumb, unsure what this change was trying to achieve but we don't want to merge it like this.
| @@ -1,6 +1,5 @@ | |||
| .breadcrumb-item { | |||
| display: inline-block; | |||
| margin-left: -$spacer-1; | |||
There was a problem hiding this comment.
We don't want the margin left on the first breadcrumb, but we need it on the others, this change makes the spacing either side of the / uneven.
| @@ -1,11 +1,12 @@ | |||
| { | |||
| "version": "6.0.2", | |||
| "version": "6.0.3", | |||
There was a problem hiding this comment.
Should this be a minor bump seeing as there are minor changes to packages within it?
broccolini
reviewed
Dec 19, 2017
| @@ -1,6 +1,6 @@ | |||
| .breadcrumb-item { | |||
| display: inline-block; | |||
| margin-left: -$spacer-1; | |||
| margin-left: -0.35em; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP pr for Primer 10.2.0 minor release
Tracking issue here: #406
Ship checklist