Do not suppress opacity transition for tooltipped-no-delay #307
Conversation
|
I'm not entirely sure how Travis failed here. Help? |
|
Thanks @astorije I agree with this change. Sorry about the failing tests, we recently setup a new publishing flow and tests fail from forks at the moment, but we'll get that fixed soon. Also heads up for the future pr's, they should be from the dev branch rather than master. Here's the updated contribution guidelines. I'd like to make a few other small updates to tooltips so I'll pull your changes into a new pr and will drop a link here when that's ready. |
As far as I understand (the git history is not too easy to follow on this repo :/), when `tooltipped-no-delay` was added, there were no animations/transitions on the tooltip. This commit removes the delay, so that the transition starts immediately, instead of suppressing the transition entirely. It effectively makes the 2 variants differ by only the initial delay (like the name suggests).
|
Hey @broccolini, thanks for your answer! I have rebased this branch with latest Sorry for opening this PR on the wrong branch. I did notice this on the CONTRIBUTING file, then it slipped my mind... Rebasing on it or starting something new locally aren't the easiest thing, because (on my local fork, at least), |
We've debated this idea, we don't really like the idea of not showing Master because then if people don't notice the branch is set to dev they might confused about seeing things that are not yet published. To make it clearer that you need to branch off dev, we've added a pull request template which makes it a lot more obvious. Hopefully that helps. I'm going to merge this into our v10 branch which we're hoping to ship next week 🎉. Thanks for contributing! |
As far as I understand (the git history is not too easy to follow on this repo :/), when
tooltipped-no-delaywas added here, there were no animations/transitions on the tooltip.This commit removes the delay, so that the transition starts immediately, instead of suppressing the transition entirely. It effectively makes the 2 variants differ by only the initial delay (like the name suggests).
I noticed that on a project where both variants are used at the same time: there are tooltips on buttons (which warrant the delay), and tooltips on help icons, which have no delay. The difference in delay did not shock the eye, but the lack of transition felt off :)